Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SIMSBIOHUB-194-2:user add bug #1089

Merged
merged 1 commit into from
Sep 12, 2023
Merged

SIMSBIOHUB-194-2:user add bug #1089

merged 1 commit into from
Sep 12, 2023

Conversation

KjartanE
Copy link
Contributor

Links to Jira Tickets

  • {Include a link to all applicable Jira tickets}

Description of Changes

  • {List all relevant code changes. Include any changes to the business workflow that might not be obvious to the reviewers of this PR.}

Testing Notes

  • {List any relevant testing considerations, necessary pre-reqs, and areas of the app to focus on. Specifically, include anything that will help the reviewers of this PR verify the code is functioning as expected.}

@github-actions
Copy link

Openshift URLs for the PR Deployment:

@sonarcloud
Copy link

sonarcloud bot commented Sep 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Sep 12, 2023 •
edited
Loading

Codecov Report

Merging #1089 (ab4733d) into dev (0106937) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev    #1089   +/-   ##
=======================================
  Coverage   64.51%   64.52%           
=======================================
  Files         464      464           
  Lines       13921    13918    -3     
  Branches     2200     2199    -1     
=======================================
- Hits         8981     8980    -1     
+ Misses       4374     4373    -1     
+ Partials      566      565    -1
Files Changed Coverage Δ
api/src/paths/user/add.ts 56.41% <ø> (+1.64%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

al-rosenthal
al-rosenthal approved these changes Sep 12, 2023
View reviewed changes
Copy link
Contributor

@al-rosenthal al-rosenthal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐎

@KjartanE KjartanE merged commit 9d6f347 into dev Sep 12, 2023
21 checks passed
@KjartanE KjartanE deleted the SIMSBIOHUB-194-2 branch September 12, 2023 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@curtisupshall curtisupshall curtisupshall approved these changes

@al-rosenthal al-rosenthal al-rosenthal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KjartanE @al-rosenthal @curtisupshall